Skip to content

Address Feedback#3628

Merged
patrick-ogrady merged 34 commits into
cl/rm-double-certifyfrom
certify-nits
Apr 20, 2026
Merged

Address Feedback#3628
patrick-ogrady merged 34 commits into
cl/rm-double-certifyfrom
certify-nits

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

@patrick-ogrady patrick-ogrady commented Apr 18, 2026 •
edited
Loading

Related: #3543

  • Add marshal equivocation tests (verify superseded by certify -> ensure certify is persisted)
  • Add a regression test for a digest in multiple views (with earlier getting pruned)?

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 18, 2026 •
edited
Loading

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs		 commonware-mcp ce44aea Apr 20 2026, 05:17 AM

@patrick-ogrady patrick-ogrady marked this pull request as draft April 18, 2026 23:53
patrick-ogrady
patrick-ogrady commented Apr 18, 2026
View reviewed changes
Comment thread consensus/src/marshal/standard/mod.rs
patrick-ogrady
patrick-ogrady commented Apr 18, 2026
View reviewed changes
Comment thread consensus/src/simplex/engine.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 18, 2026
View reviewed changes
Comment thread consensus/src/simplex/engine.rs Outdated
cursor[bot]
cursor Bot reviewed Apr 19, 2026
View reviewed changes
Comment thread consensus/src/simplex/actors/voter/mod.rs
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 19, 2026 •
edited
Loading

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce44aea
Status: ✅  Deploy successful!
Preview URL: https://6279f2b8.monorepo-eu0.pages.dev
Branch Preview URL: https://certify-nits.monorepo-eu0.pages.dev

View logs

patrick-ogrady
patrick-ogrady commented Apr 19, 2026
View reviewed changes
Comment thread consensus/src/marshal/standard/deferred.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 19, 2026
View reviewed changes
Comment thread consensus/src/marshal/core/actor.rs Outdated
@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

patrick-ogrady commented Apr 19, 2026

bugbot run

patrick-ogrady
patrick-ogrady commented Apr 19, 2026
View reviewed changes
Comment thread p2p/src/authenticated/lookup/network.rs Outdated
cursor[bot]
cursor Bot reviewed Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit e1f6db9. Configure here.

@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

patrick-ogrady commented Apr 19, 2026

bugbot run

patrick-ogrady
patrick-ogrady commented Apr 19, 2026
View reviewed changes
Comment thread consensus/src/marshal/core/actor.rs Outdated
cursor[bot]
cursor Bot reviewed Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit fc9d8b4. Configure here.

patrick-ogrady
patrick-ogrady commented Apr 19, 2026
View reviewed changes
Comment thread storage/src/archive/prunable/mod.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 19, 2026
View reviewed changes
Comment thread p2p/src/authenticated/discovery/network.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 20, 2026
View reviewed changes
Comment thread consensus/src/marshal/mocks/harness.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 20, 2026
View reviewed changes
Comment thread consensus/src/marshal/resolver/handler.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 20, 2026
View reviewed changes
Comment thread consensus/src/marshal/resolver/handler.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 20, 2026
View reviewed changes
Comment thread consensus/src/marshal/standard/mod.rs Outdated
patrick-ogrady
patrick-ogrady commented Apr 20, 2026
View reviewed changes
Comment thread consensus/src/marshal/application/validation.rs
@patrick-ogrady patrick-ogrady marked this pull request as ready for review April 20, 2026 05:13
@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

patrick-ogrady commented Apr 20, 2026

bugbot run

@patrick-ogrady patrick-ogrady merged commit a2e88d4 into cl/rm-double-certify Apr 20, 2026
168 checks passed
@patrick-ogrady patrick-ogrady deleted the certify-nits branch April 20, 2026 05:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 94.86824% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.84%. Comparing base (0b1f28b) to head (ce44aea).
⚠️ Report is 3 commits behind head on cl/rm-double-certify.

Files with missing lines Patch % Lines
consensus/src/marshal/standard/mod.rs 92.20% 14 Missing and 3 partials ⚠️
p2p/src/authenticated/discovery/network.rs 0.00% 5 Missing ⚠️
p2p/src/authenticated/lookup/network.rs 0.00% 5 Missing ⚠️
consensus/src/marshal/coding/marshaled.rs 77.77% 1 Missing and 1 partial ⚠️
consensus/src/marshal/coding/mod.rs 96.49% 1 Missing and 1 partial ⚠️
consensus/src/simplex/engine.rs 66.66% 2 Missing ⚠️
consensus/src/marshal/standard/deferred.rs 83.33% 0 Missing and 1 partial ⚠️
consensus/src/marshal/standard/inline.rs 50.00% 0 Missing and 1 partial ⚠️
consensus/src/simplex/actors/voter/mod.rs 98.73% 1 Missing ⚠️
storage/src/archive/mod.rs 97.05% 0 Missing and 1 partial ⚠️ 
@@                   Coverage Diff                    @@
##           cl/rm-double-certify    #3628      +/-   ##
========================================================
+ Coverage                 95.81%   95.84%   +0.03%     
========================================================
  Files                       440      440              
  Lines                    170849   171195     +346     
  Branches                   3985     3978       -7     
========================================================
+ Hits                     163694   164077     +383     
+ Misses                     5888     5853      -35     
+ Partials                   1267     1265       -2
Files with missing lines Coverage Δ
consensus/src/marshal/application/validation.rs 100.00% <100.00%> (ø)
...nsus/src/marshal/application/verification_tasks.rs 100.00% <100.00%> (+42.10%) ⬆️
consensus/src/marshal/core/actor.rs 92.24% <100.00%> (+0.72%) ⬆️
consensus/src/marshal/core/mailbox.rs 100.00% <100.00%> (+7.62%) ⬆️
consensus/src/marshal/mocks/harness.rs 98.63% <100.00%> (+0.06%) ⬆️
consensus/src/marshal/resolver/handler.rs 94.05% <100.00%> (+0.39%) ⬆️
consensus/src/marshal/standard/validation.rs 85.34% <100.00%> (+0.07%) ⬆️
storage/src/archive/immutable/mod.rs 100.00% <ø> (ø)
storage/src/archive/prunable/mod.rs 100.00% <100.00%> (ø)
consensus/src/marshal/standard/deferred.rs 90.07% <83.33%> (+0.05%) ⬆️
... and 9 more

... and 17 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1f28b...ce44aea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

@patrick-ogrady patrick-ogrady

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@patrick-ogrady